Testing services
This commit is contained in:
@@ -45,7 +45,6 @@ class BoardService {
|
||||
|
||||
public function __construct(
|
||||
BoardMapper $boardMapper,
|
||||
ILogger $logger,
|
||||
IL10N $l10n,
|
||||
LabelMapper $labelMapper,
|
||||
AclMapper $aclMapper,
|
||||
|
||||
@@ -92,6 +92,7 @@ class CardService {
|
||||
public function reorder($id, $stackId, $order) {
|
||||
$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);
|
||||
$cards = $this->cardMapper->findAll($stackId);
|
||||
$result = [];
|
||||
$i = 0;
|
||||
foreach ($cards as $card) {
|
||||
if($card->getArchived()) {
|
||||
@@ -109,10 +110,10 @@ class CardService {
|
||||
$card->setOrder($i++);
|
||||
}
|
||||
$this->cardMapper->update($card);
|
||||
$result[$card->getOrder()] = $card;
|
||||
}
|
||||
// FIXME: return reordered cards without an additional db query
|
||||
$cards = $this->cardMapper->findAll($stackId);
|
||||
return $cards;
|
||||
|
||||
return $result;
|
||||
}
|
||||
|
||||
public function archive($id) {
|
||||
|
||||
@@ -42,8 +42,7 @@ class LabelService {
|
||||
|
||||
public function find($labelId) {
|
||||
$this->permissionService->checkPermission($this->labelMapper, $labelId, Acl::PERMISSION_READ);
|
||||
$label = $this->labelMapper->find($labelId);
|
||||
return $label;
|
||||
return $this->labelMapper->find($labelId);
|
||||
}
|
||||
|
||||
public function create($title, $color, $boardId) {
|
||||
|
||||
@@ -40,17 +40,13 @@ class StackService {
|
||||
|
||||
private $stackMapper;
|
||||
private $cardMapper;
|
||||
private $logger;
|
||||
private $labelMapper;
|
||||
private $permissionService;
|
||||
|
||||
public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, ILogger $logger,
|
||||
IL10N $l10n,
|
||||
ITimeFactory $timeFactory, PermissionService $permissionService) {
|
||||
public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, PermissionService $permissionService) {
|
||||
$this->stackMapper = $stackMapper;
|
||||
$this->cardMapper = $cardMapper;
|
||||
$this->labelMapper = $labelMapper;
|
||||
$this->logger = $logger;
|
||||
$this->permissionService = $permissionService;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user