ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

More testing for dark magic middleware

Browse Source
This commit is contained in:
Julius Haertl
2017-01-10 17:07:55 +01:00
parent f0aa3777b2
commit 6d0ebb7d73
1 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/unit/Middleware/SharingMiddlewareTest.php
View File

@@ -73,12 +73,15 @@ class SharingMiddlewareTest extends \PHPUnit_Framework_TestCase {
public function dataBeforeController() { public function dataBeforeController() {
return [ return [
['GET', '\OCA\Deck\Controller\PageController', 'index', null, true], ['GET', '\OCA\Deck\Controller\PageController', 'index', false, true, 123],
['GET', '\OCA\Deck\Controller\BoardController', 'index', null, true], ['GET', '\OCA\Deck\Controller\BoardController', 'index', false, true, 123],
['GET', '\OCA\Deck\Controller\BoardController', 'read', true, true], ['GET', '\OCA\Deck\Controller\BoardController', 'read', true, true, 123],
['GET', '\OCA\Deck\Controller\BoardController', 'read', false, true, NoPermissionException::class], ['GET', '\OCA\Deck\Controller\BoardController', 'read', true, true, 123, NoPermissionException::class],
['GET', '\OCA\Deck\Controller\CardController', 'read', false, true, NoPermissionException::class], ['GET', '\OCA\Deck\Controller\BoardController', 'read', false, false, null, NotFoundException::class],
['POST', '\OCA\Deck\Controller\CardController', 'reorder', false, true, NoPermissionException::class], ['GET', '\OCA\Deck\Controller\CardController', 'read', true, true, 123, NoPermissionException::class],
['POST', '\OCA\Deck\Controller\CardController', 'reorder', true, true, 123, NoPermissionException::class],
['PUT', '\OCA\Deck\Controller\BoardController', 'update', true, false, 123, NoPermissionException::class],
]; ];
} }
@@ -87,24 +90,28 @@ class SharingMiddlewareTest extends \PHPUnit_Framework_TestCase {
* @param $controllerClass * @param $controllerClass
* @param $methodName * @param $methodName
*/ */
public function testBeforeController($method, $controllerClass, $methodName, $getPermission, $success, $exception=null) { public function testBeforeController($method, $controllerClass, $methodName, $getPermission, $success, $boardId, $exception=null) {
$controller = $this->getMockBuilder($controllerClass) $controller = $this->getMockBuilder($controllerClass)
->disableOriginalConstructor()->getMock(); ->disableOriginalConstructor()->getMock();
$mapper = $this->getMockBuilder(IPermissionMapper::class) $mapper = $this->getMockBuilder(IPermissionMapper::class)
->disableOriginalConstructor()->getMock(); ->disableOriginalConstructor()->getMock();
$mapper->expects($this->any())->method('findBoardId')->willReturn(123); $mapper->expects($this->any())->method('findBoardId')->willReturn($boardId);
$mapper->expects($this->any())->method('isOwner')->willReturn(false); $mapper->expects($this->any())->method('isOwner')->willReturn(false);
$user = $this->getMockBuilder(IUser::class) $user = $this->getMockBuilder(IUser::class)
->disableOriginalConstructor()->getMock(); ->disableOriginalConstructor()->getMock();
$user->expects($this->once())->method('getUID')->willReturn('user1'); $user->expects($this->once())->method('getUID')->willReturn('user1');
$this->reflector->reflect($controller, $methodName); $controllerInstance = \OC::$server->query($controllerClass);
$this->reflector->reflect($controllerInstance, $methodName);
$this->container->expects($this->any()) $this->container->expects($this->any())
->method('query')->willReturn($mapper); ->method('query')->willReturn($mapper);
$this->userSession->expects($this->exactly(2))->method('getUser')->willReturn($user); $this->userSession->expects($this->exactly(2))->method('getUser')->willReturn($user);
$this->request->expects($this->once())->method('getMethod')->willReturn($method); $this->request->expects($this->once())->method('getMethod')->willReturn($method);
if($getPermission) { if($getPermission === true) {
$this->permissionService->expects($this->any())->method('getPermission')->willReturn($getPermission); $this->permissionService
->expects($this->once())
->method('getPermission')
->willReturn($getPermission);
} }
if($success) { if($success) {