ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #7154 from vdiezel/fix-reorder-card-rest-endpoint

Browse Source 
fix: parse arguments to CardService.reorder correctly to int
This commit is contained in:
Luka Trovic
2025-09-26 15:26:44 +02:00
committed by GitHub
parent f347f96474 eee35ac6ad
commit 6a7c02d8d8
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Controller/CardApiController.php
View File

@@ -185,7 +185,7 @@ class CardApiController extends ApiController {
* Reorder cards * Reorder cards
*/ */
public function reorder($stackId, $order) { public function reorder($stackId, $order) {
$card = $this->cardService->reorder($this->request->getParam('cardId'), $stackId, $order); $card = $this->cardService->reorder((int)$this->request->getParam('cardId'), (int)$stackId, (int)$order);
return new DataResponse($card, HTTP::STATUS_OK); return new DataResponse($card, HTTP::STATUS_OK);
} }
} }

2
lib/Service/CardService.php
View File

@@ -439,7 +439,7 @@ class CardService {
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException * @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
* @throws BadRequestException * @throws BadRequestException
*/ */
public function reorder($id, $stackId, $order) { public function reorder(int $id, int $stackId, int $order) {
$this->cardServiceValidator->check(compact('id', 'stackId', 'order')); $this->cardServiceValidator->check(compact('id', 'stackId', 'order'));
$this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT); $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT);