ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

chore: Cleanup some outdated fixme comments

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2023-08-11 18:23:56 +02:00
parent caebc01a9f
commit 66728431b8
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/Service/Importer/BoardImportCommandService.php
View File

@@ -76,7 +76,6 @@ class BoardImportCommandService extends BoardImportService {
} }
protected function validateConfig(): void { protected function validateConfig(): void {
// FIXME: Make config optional for deck plain importer (but use a call on the importer insterad)
try { try {
$config = $this->getInput()->getOption('config'); $config = $this->getInput()->getOption('config');
if (!$config) { if (!$config) {

3
lib/Service/Importer/Systems/DeckJsonService.php
View File

@@ -184,7 +184,6 @@ class DeckJsonService extends ABoardImportService {
$card->stackId = $index; $card->stackId = $index;
$this->tmpCards[] = $card; $this->tmpCards[] = $card;
} }
// TODO: check older exports as currently there is a bug that adds lists to it with different index
} }
} }
return $return; return $return;
@@ -221,7 +220,6 @@ class DeckJsonService extends ABoardImportService {
$board = $this->getImportService()->getData(); $board = $this->getImportService()->getData();
$return = []; $return = [];
foreach ($board->acl as $aclData) { foreach ($board->acl as $aclData) {
// FIXME: Figure out mapping
$acl = new Acl(); $acl = new Acl();
$acl->setBoardId($this->getImportService()->getBoard()->getId()); $acl->setBoardId($this->getImportService()->getBoard()->getId());
$acl->setType($aclData->type); $acl->setType($aclData->type);
@@ -236,7 +234,6 @@ class DeckJsonService extends ABoardImportService {
if ($participant) { if ($participant) {
$return[] = $acl; $return[] = $acl;
} }
// TODO: Once we have error collection we should catch non-existing users
} }
return $return; return $return;
} }