From 3f34577064f3810a0f54ba7d7534ac9692f9799c Mon Sep 17 00:00:00 2001 From: Faraz Samapoor Date: Thu, 4 May 2023 17:08:53 +0330 Subject: [PATCH] Refactors lib\Activity\DeckProvider.php to improve code readability. Converts 'strpos()' calls to 'str_contains()' to improve code readability. Signed-off-by: Faraz Samapoor --- lib/Activity/DeckProvider.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php index 5a79275cd..7808ef013 100644 --- a/lib/Activity/DeckProvider.php +++ b/lib/Activity/DeckProvider.php @@ -186,28 +186,28 @@ class DeckProvider implements IProvider { private function getIcon(IEvent $event) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('deck', 'deck-dark.svg'))); - if (strpos($event->getSubject(), '_update') !== false) { + if (str_contains($event->getSubject(), '_update')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('files', 'change.svg'))); } - if (strpos($event->getSubject(), '_create') !== false) { + if (str_contains($event->getSubject(), '_create')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('files', 'add-color.svg'))); } - if (strpos($event->getSubject(), '_delete') !== false) { + if (str_contains($event->getSubject(), '_delete')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('files', 'delete-color.svg'))); } - if (strpos($event->getSubject(), 'archive') !== false) { + if (str_contains($event->getSubject(), 'archive')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('deck', 'archive.svg'))); } - if (strpos($event->getSubject(), '_restore') !== false) { + if (str_contains($event->getSubject(), '_restore')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'actions/history.svg'))); } - if (strpos($event->getSubject(), 'attachment_') !== false) { + if (str_contains($event->getSubject(), 'attachment_')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'places/files.svg'))); } - if (strpos($event->getSubject(), 'comment_') !== false) { + if (str_contains($event->getSubject(), 'comment_')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'actions/comment.svg'))); } - if (strpos($event->getSubject(), 'label_') !== false) { + if (str_contains($event->getSubject(), 'label_')) { $event->setIcon($this->urlGenerator->getAbsoluteURL($this->urlGenerator->imagePath('core', 'actions/tag.svg'))); } return $event;