ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

perf: Skip doing a query just to check if a board is deleted

Browse Source 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
This commit is contained in:
Julius Knorr
2025-04-08 22:13:11 +02:00
committed by backportbot[bot]
parent 3a454b75e0
commit 5ca18b1d32
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Sharing/DeckShareProvider.php
View File

@@ -270,7 +270,7 @@ class DeckShareProvider implements \OCP\Share\IShareProvider {
private function applyBoardPermission($share, $permissions, $userId) { private function applyBoardPermission($share, $permissions, $userId) {
try { try {
$this->permissionService->checkPermission($this->cardMapper, $share->getSharedWith(), Acl::PERMISSION_EDIT, $userId); $this->permissionService->checkPermission($this->cardMapper, $share->getSharedWith(), Acl::PERMISSION_EDIT, $userId, true);
} catch (NoPermissionException $e) { } catch (NoPermissionException $e) {
$permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE; $permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_UPDATE;
$permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE; $permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_CREATE;
@@ -278,7 +278,7 @@ class DeckShareProvider implements \OCP\Share\IShareProvider {
} }
try { try {
$this->permissionService->checkPermission($this->cardMapper, $share->getSharedWith(), Acl::PERMISSION_SHARE, $userId); $this->permissionService->checkPermission($this->cardMapper, $share->getSharedWith(), Acl::PERMISSION_SHARE, $userId, true);
} catch (NoPermissionException $e) { } catch (NoPermissionException $e) {
$permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_SHARE; $permissions &= Constants::PERMISSION_ALL - Constants::PERMISSION_SHARE;
} }
@@ -747,6 +747,8 @@ class DeckShareProvider implements \OCP\Share\IShareProvider {
$qb->expr()->eq('s.item_type', $qb->createNamedParameter('folder')) $qb->expr()->eq('s.item_type', $qb->createNamedParameter('folder'))
)); ));
$qb->andWhere($qb->expr()->eq('dc.deleted_at', $qb->createNamedParameter(0, IQueryBuilder::PARAM_INT)));
$cursor = $qb->execute(); $cursor = $qb->execute();
while ($data = $cursor->fetch()) { while ($data = $cursor->fetch()) {
if (!$this->isAccessibleResult($data)) { if (!$this->isAccessibleResult($data)) {