From 5b81f4b614fcab70125a87c3ee0c872d80295a6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Fri, 11 Aug 2023 18:23:56 +0200 Subject: [PATCH] chore: Cleanup some outdated fixme comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- lib/Service/Importer/BoardImportCommandService.php | 1 - lib/Service/Importer/Systems/DeckJsonService.php | 3 --- 2 files changed, 4 deletions(-) diff --git a/lib/Service/Importer/BoardImportCommandService.php b/lib/Service/Importer/BoardImportCommandService.php index 64d57622c..7be2877d8 100644 --- a/lib/Service/Importer/BoardImportCommandService.php +++ b/lib/Service/Importer/BoardImportCommandService.php @@ -76,7 +76,6 @@ class BoardImportCommandService extends BoardImportService { } protected function validateConfig(): void { - // FIXME: Make config optional for deck plain importer (but use a call on the importer insterad) try { $config = $this->getInput()->getOption('config'); if (!$config) { diff --git a/lib/Service/Importer/Systems/DeckJsonService.php b/lib/Service/Importer/Systems/DeckJsonService.php index 4de3ec459..4e4af4144 100644 --- a/lib/Service/Importer/Systems/DeckJsonService.php +++ b/lib/Service/Importer/Systems/DeckJsonService.php @@ -184,7 +184,6 @@ class DeckJsonService extends ABoardImportService { $card->stackId = $index; $this->tmpCards[] = $card; } - // TODO: check older exports as currently there is a bug that adds lists to it with different index } } return $return; @@ -221,7 +220,6 @@ class DeckJsonService extends ABoardImportService { $board = $this->getImportService()->getData(); $return = []; foreach ($board->acl as $aclData) { - // FIXME: Figure out mapping $acl = new Acl(); $acl->setBoardId($this->getImportService()->getBoard()->getId()); $acl->setType($aclData->type); @@ -236,7 +234,6 @@ class DeckJsonService extends ABoardImportService { if ($participant) { $return[] = $acl; } - // TODO: Once we have error collection we should catch non-existing users } return $return; }