Merge pull request #3746 from nextcloud/dependabot/npm_and_yarn/master/nextcloud/eslint-config-8.0.0

build(deps-dev): Bump @nextcloud/eslint-config from 6.1.2 to 8.0.0

package.json

@@ -72,7 +72,7 @@
 	"devDependencies": {
 		"@nextcloud/babel-config": "^1.0.0",
 		"@nextcloud/browserslist-config": "^2.2.0",
-		"@nextcloud/eslint-config": "^6.1.2",
+		"@nextcloud/eslint-config": "^8.0.0",
 		"@nextcloud/stylelint-config": "^2.1.2",
 		"@nextcloud/webpack-vue-config": "^5.0.0",
 		"@relative-ci/agent": "^3.1.2",

src/App.vue

@@ -27,8 +27,7 @@
 			<router-view />
 		</AppContent>
 
-		<Modal
+		<Modal v-if="cardDetailsInModal && $route.params.cardId"
-			v-if="cardDetailsInModal && $route.params.cardId"
 			:clear-view-delay="0"
 			:title="t('deck', 'Card details')"
 			@close="hideModal()">

src/components/AttachmentDragAndDrop.vue

@@ -27,17 +27,14 @@
 		@drop.prevent="handleDropFiles">
 		<slot />
 		<transition name="fade" mode="out-in">
-			<div
+			<div v-show="isDraggingOver"
-				v-show="isDraggingOver"
 				class="dragover">
 				<div class="drop-hint">
-					<div
+					<div class="drop-hint__icon"
-						class="drop-hint__icon"
 						:class="{
 							'icon-upload' : !isReadOnly,
 							'icon-error' : isReadOnly}" />
-					<h2
+					<h2 class="drop-hint__text">
-						class="drop-hint__text">
 						{{ dropHintText }}
 					</h2>
 				</div>

src/components/Controls.vue

@@ -79,8 +79,7 @@
 					<div v-if="filterVisible" class="filter">
 						<h3>{{ t('deck', 'Filter by tag') }}</h3>
 						<div v-for="label in labelsSorted" :key="label.id" class="filter--item">
-							<input
+							<input :id="label.id"
-								:id="label.id"
 								v-model="filter.tags"
 								type="checkbox"
 								class="checkbox"
@@ -91,8 +90,7 @@
 
 						<h3>{{ t('deck', 'Filter by assigned user') }}</h3>
 						<div class="filter--item">
-							<input
+							<input id="unassigned"
-								id="unassigned"
 								v-model="filter.unassigned"
 								type="checkbox"
 								class="checkbox"
@@ -102,8 +100,7 @@
 							<label for="unassigned">{{ t('deck', 'Unassigned') }}</label>
 						</div>
 						<div v-for="user in board.users" :key="user.uid" class="filter--item">
-							<input
+							<input :id="user.uid"
-								:id="user.uid"
 								v-model="filter.users"
 								type="checkbox"
 								class="checkbox"
@@ -115,8 +112,7 @@
 						<h3>{{ t('deck', 'Filter by due date') }}</h3>
 
 						<div class="filter--item">
-							<input
+							<input id="overdue"
-								id="overdue"
 								v-model="filter.due"
 								type="radio"
 								class="radio"
@@ -127,8 +123,7 @@
 						</div>
 
 						<div class="filter--item">
-							<input
+							<input id="dueToday"
-								id="dueToday"
 								v-model="filter.due"
 								type="radio"
 								class="radio"
@@ -139,8 +134,7 @@
 						</div>
 
 						<div class="filter--item">
-							<input
+							<input id="dueWeek"
-								id="dueWeek"
 								v-model="filter.due"
 								type="radio"
 								class="radio"
@@ -151,8 +145,7 @@
 						</div>
 
 						<div class="filter--item">
-							<input
+							<input id="dueMonth"
-								id="dueMonth"
 								v-model="filter.due"
 								type="radio"
 								class="radio"
@@ -163,8 +156,7 @@
 						</div>
 
 						<div class="filter--item">
-							<input
+							<input id="noDue"
-								id="noDue"
 								v-model="filter.due"
 								type="radio"
 								class="radio"
@@ -181,8 +173,7 @@
 				</Popover>
 
 				<Actions>
-					<ActionButton
+					<ActionButton icon="icon-archive"
-						icon="icon-archive"
 						@click="toggleShowArchived">
 						{{ showArchived ? t('deck', 'Hide archived cards') : t('deck', 'Show archived cards') }}
 					</ActionButton>
@@ -267,9 +258,6 @@ export default {
 			return [...this.board.labels].sort((a, b) => (a.title < b.title) ? -1 : 1)
 		},
 	},
-	beforeDestroy() {
-		this.setPageTitle('')
-	},
 	watch: {
 		board(current, previous) {
 			if (current?.id !== previous?.id) {
@@ -280,6 +268,9 @@ export default {
 			}
 		},
 	},
+	beforeDestroy() {
+		this.setPageTitle('')
+	},
 	methods: {
 		beforeSetFilter(e) {
 			if (this.filter.due === e.target.value) {

src/components/board/DeletedTabSidebar.vue

@@ -8,8 +8,7 @@
 					<span>{{ deletedStack.title }}</span>
 					<span class="timestamp">{{ relativeDate(deletedStack.deletedAt*1000) }}</span>
 				</div>
-				<button
+				<button :title="t('settings', 'Undo')"
-					:title="t('settings', 'Undo')"
 					class="app-navigation-entry-deleted-button icon-history"
 					@click="stackUndoDelete(deletedStack)" />
 			</li>
@@ -23,8 +22,7 @@
 					<span>{{ deletedCard.title }}</span>
 					<span class="timestamp">{{ relativeDate(deletedCard.deletedAt*1000) }}</span>
 				</div>
-				<button
+				<button :title="t('settings', 'Undo')"
-					:title="t('settings', 'Undo')"
 					class="app-navigation-entry-deleted-button icon-history"
 					@click="cardUndoDelete(deletedCard)" />
 			</li>

src/components/board/SharingTabSidebar.vue

@@ -1,7 +1,6 @@
 <template>
 	<div>
-		<Multiselect
+		<Multiselect v-if="canShare"
-			v-if="canShare"
 			v-model="addAcl"
 			:placeholder="t('deck', 'Share board with a user, group or circle …')"
 			:options="formatedSharees"
@@ -21,8 +20,7 @@
 			</template>
 		</Multiselect>
 
-		<ul
+		<ul id="shareWithList"
-			id="shareWithList"
 			class="shareWithList">
 			<li>
 				<Avatar :user="board.owner.uid" />
@@ -214,7 +212,7 @@ export default {
 							this.isLoading = true
 							await this.$store.dispatch('transferOwnership', {
 								boardId: this.board.id,
-								newOwner
+								newOwner,
 							})
 							const successMessage = t('deck', 'The board has been transferred to {user}', { user: newOwner })
 							showSuccess(successMessage)

src/components/card/CardSidebar.vue

@@ -62,8 +62,7 @@
 			<CardSidebarTabAttachments :card="currentCard" />
 		</AppSidebarTab>
 
-		<AppSidebarTab
+		<AppSidebarTab id="comments"
-			id="comments"
 			:order="2"
 			:name="t('deck', 'Comments')"
 			icon="icon-comment">

src/components/card/CardSidebarTabAttachments.vue

@@ -21,8 +21,7 @@
   -->
 
 <template>
-	<AttachmentList
+	<AttachmentList :card-id="card.id"
-		:card-id="card.id"
 		:removable="true"
 		@delete-attachment="deleteAttachment"
 		@restore-attachment="restoreAttachment" />

src/components/card/CommentItem.vue

@@ -51,8 +51,7 @@
 		</div>
 		<CommentItem v-if="comment.replyTo" :reply="true" :comment="comment.replyTo" />
 		<div v-show="!edit" ref="richTextElement">
-			<RichText
+			<RichText class="comment--content"
-				class="comment--content"
 				:text="richText(comment)"
 				:arguments="richArgs(comment)"
 				:autolink="true" />

src/components/card/Description.vue

@@ -63,8 +63,7 @@
 		<Modal v-if="modalShow" :title="t('deck', 'Choose attachment')" @close="modalShow=false">
 			<div class="modal__content">
 				<h3>{{ t('deck', 'Choose attachment') }}</h3>
-				<AttachmentList
+				<AttachmentList :card-id="card.id"
-					:card-id="card.id"
 					:selectable="true"
 					@select-attachment="addAttachment" />
 			</div>

src/components/cards/AvatarList.vue

@@ -56,8 +56,7 @@
 
 		<div class="avatar-print-list">
 			<div v-for="user in avatarUsers" :key="user.id" class="avatar-print-list-item">
-				<Avatar
+				<Avatar class="avatar-print-list-avatar"
-					class="avatar-print-list-avatar"
 					:user="user.participant.uid"
 					:display-name="user.participant.displayname"
 					:disable-menu="true"

src/components/cards/CardMenu.vue

@@ -139,7 +139,7 @@ export default {
 
 		boardId() {
 			return this.card?.boardId ? this.card.boardId : this.$route.params.id
-		}
+		},
 	},
 	methods: {
 		openCard() {

src/components/navigation/AppNavigation.vue

@@ -23,26 +23,22 @@
 <template>
 	<AppNavigationVue :class="{'icon-loading': loading}">
 		<template #list>
-			<AppNavigationItem
+			<AppNavigationItem :title="t('deck', 'Upcoming cards')"
-				:title="t('deck', 'Upcoming cards')"
 				icon="icon-calendar-dark"
 				:exact="true"
 				to="/" />
-			<AppNavigationBoardCategory
+			<AppNavigationBoardCategory id="deck-navigation-all"
-				id="deck-navigation-all"
 				to="/board"
 				:text="t('deck', 'All boards')"
 				:boards="noneArchivedBoards"
 				:open-on-add-boards="true"
 				icon="icon-deck" />
-			<AppNavigationBoardCategory
+			<AppNavigationBoardCategory id="deck-navigation-archived"
-				id="deck-navigation-archived"
 				to="/board/archived"
 				:text="t('deck', 'Archived boards')"
 				:boards="archivedBoards"
 				icon="icon-archive" />
-			<AppNavigationBoardCategory
+			<AppNavigationBoardCategory id="deck-navigation-shared"
-				id="deck-navigation-shared"
 				to="/board/shared"
 				:text="t('deck', 'Shared with you')"
 				:boards="sharedBoards"

src/components/navigation/AppNavigationBoard.vue

@@ -35,8 +35,7 @@
 
 		<template v-if="!deleted" slot="actions">
 			<template v-if="!isDueSubmenuActive">
-				<ActionButton
+				<ActionButton icon="icon-info"
-					icon="icon-info"
 					:close-after-click="true"
 					@click="actionDetails">
 					{{ t('deck', 'Board details') }}
@@ -73,31 +72,27 @@
 
 			<!-- Due date reminder settings -->
 			<template v-if="isDueSubmenuActive">
-				<ActionButton
+				<ActionButton :icon="updateDueSetting ? 'icon-loading-small' : 'icon-view-previous'"
-					:icon="updateDueSetting ? 'icon-loading-small' : 'icon-view-previous'"
 					:disabled="updateDueSetting"
 					@click="isDueSubmenuActive=false">
 					{{ t('deck', 'Due date reminders') }}
 				</ActionButton>
 
-				<ActionButton
+				<ActionButton name="notification"
-					name="notification"
 					icon="icon-sound"
 					:disabled="updateDueSetting"
 					:class="{ 'forced-active': board.settings['notify-due'] === 'all' }"
 					@click="updateSetting('notify-due', 'all')">
 					{{ t('deck', 'All cards') }}
 				</ActionButton>
-				<ActionButton
+				<ActionButton name="notification"
-					name="notification"
 					icon="icon-user"
 					:disabled="updateDueSetting"
 					:class="{ 'forced-active': board.settings['notify-due'] === 'assigned' }"
 					@click="updateSetting('notify-due', 'assigned')">
 					{{ t('deck', 'Assigned cards') }}
 				</ActionButton>
-				<ActionButton
+				<ActionButton name="notification"
-					name="notification"
 					icon="icon-sound-off"
 					:disabled="updateDueSetting"
 					:class="{ 'forced-active': board.settings['notify-due'] === 'off' }"

src/components/search/Placeholder.vue

@@ -18,8 +18,7 @@
 				</linearGradient>
 			</defs>
 		</svg>
-		<svg
+		<svg class="card-placeholder__placeholder"
-			class="card-placeholder__placeholder"
 			:class="{ 'standalone': standalone }"
 			xmlns="http://www.w3.org/2000/svg"
 			fill="url(#card-placeholder__gradient)">