ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Wrote unit tests against StackApiController -> get()

Browse Source 
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
This commit is contained in:
Ryan Fletcher
2018-07-15 20:01:55 -04:00
committed by Julius Härtl
parent 891fa7b7d5
commit 5719e9f134
2 changed files with 121 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/Controller/StackApiController.php
View File

@@ -90,11 +90,15 @@ class StackApiController extends ApiController {
if ($boardError) {
return new DataResponse($boardError['message'], $boardError['status']);
}
$stack = $this->service->find($this->request->params['stackId']);
if ($stack == false || $stack == null) {
return new DataResponse("Stack not found", HTTP::STATUS_NOT_FOUND);
if (is_numeric($this->request->getParam('stackId')) === false) {
return new DataResponse('stack id must be a number', HTTP::STATUS_BAD_REQUEST);
}
$stack = $this->service->find($this->request->getParam('stackId'));
if ($stack === false || $stack === null) {
return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND);
}
return new DataResponse($stack, HTTP::STATUS_OK);
@@ -150,7 +154,7 @@ class StackApiController extends ApiController {
return new DataResponse($boardError['message'], $boardError['status']);
}
if (is_numeric($this->request->params['stackId']) === false) {
if (is_numeric($this->request->getParam('stackId')) === false) {
return new DataResponse('stack id must be a number', HTTP::STATUS_BAD_REQUEST);
}
@@ -159,10 +163,10 @@ class StackApiController extends ApiController {
}
try {
$stack = $this->service->update($this->request->params['stackId'], $title, $this->request->getParam('boardId'), $order);
$stack = $this->service->update($this->request->getParam('stackId'), $title, $this->request->getParam('boardId'), $order);
if ($stack === false || $stack === null) {
return new DataResponse('Stack not found', HTTP::STATUS_NOT_FOUND);
return new DataResponse('stack not found', HTTP::STATUS_NOT_FOUND);
}
return new DataResponse($stack, HTTP::STATUS_OK);
@@ -176,7 +180,7 @@ class StackApiController extends ApiController {
* @CORS
* @NoCSRFRequired
*
* Delete the stack specified by $this->request->params['stackId'].
* Delete the stack specified by $this->request->getParam('stackId').
*/
public function delete() {
@@ -186,11 +190,11 @@ class StackApiController extends ApiController {
return new DataResponse($boardError['message'], $boardError['status']);
}
if (is_numeric($this->request->params['stackId']) === false) {
if (is_numeric($this->request->getParam('stackId')) === false) {
return new DataResponse('stack id must be a number', HTTP::STATUS_BAD_REQUEST);
}
$stack = $this->service->delete($this->request->params['stackId']);
$stack = $this->service->delete($this->request->getParam('stackId'));
if ($stack == false || $stack == null) {
return new DataResponse('Stack Not Found', HTTP::STATUS_NOT_FOUND);