ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Code cleanup, removing unused code from older iteration.

Browse Source 
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
This commit is contained in:
Ryan Fletcher
2018-07-16 22:41:41 -04:00
committed by Julius Härtl
parent 184cd00a8b
commit 507a7fd243
3 changed files with 4 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Controller/CardApiController.php
View File

@@ -27,8 +27,7 @@
use OCP\AppFramework\Http; use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse; use OCP\AppFramework\Http\DataResponse;
use OCP\IRequest; use OCP\IRequest;
use OCA\Deck\Controller\Helper\ApiHelper;
use OCA\Deck\Service\BoardService; use OCA\Deck\Service\BoardService;
use OCA\Deck\Service\StackService; use OCA\Deck\Service\StackService;
use OCA\Deck\Service\CardService; use OCA\Deck\Service\CardService;
@@ -39,15 +38,13 @@
* @package OCA\Deck\Controller * @package OCA\Deck\Controller
*/ */
class CardApiController extends ApiController { class CardApiController extends ApiController {
private $cardService; private $cardService;
private $boardService;
private $stackService;
private $userId; private $userId;
/** /**
* @param string $appName * @param string $appName
* @param IRequest $request * @param IRequest $request
* @param CardService $service * @param CardService $cardService
* @param $userId * @param $userId
*/ */
public function __construct($appName, IRequest $request, CardService $cardService, $userId) { public function __construct($appName, IRequest $request, CardService $cardService, $userId) {

49
lib/Controller/Helper/ApiHelper.php
View File

@@ -1,49 +0,0 @@
<?php
/**
* @copyright Copyright (c) 2018 Ryan Fletcher <ryan.fletcher@codepassion.ca>
*
* @author Ryan Fletcher <ryan.fletcher@codepassion.ca>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/
namespace OCA\Deck\Controller\Helper;
use OCP\AppFramework\Http;
class ApiHelper {
public static function entityHasError($entityId, $entityName, $service) {
if (is_numeric($entityId) === false) {
$error['message'] = $entityName . ' id must be a number';
$error['status'] = HTTP::STATUS_BAD_REQUEST;
return $error;
}
$entity = $service->find($entityId);
if ($entity === false || $entity === null) {
$error['message'] = $entityName . ' not found';
$error['status'] = HTTP::STATUS_NOT_FOUND;
return $error;
}
return false;
}
}

2
lib/Controller/LabelApiController.php
View File

@@ -44,7 +44,7 @@ class LabelApiController extends ApiController {
/** /**
* @param string $appName * @param string $appName
* @param IRequest $request * @param IRequest $request
* @param LabelService $service * @param LabelService $labelService
* @param $userId * @param $userId
*/ */
public function __construct($appName, IRequest $request, LabelService $labelService, $userId) { public function __construct($appName, IRequest $request, LabelService $labelService, $userId) {