From 4e5f4df29a1813ca0b75c079339b14ca22d06e4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Fri, 9 Nov 2018 15:49:00 +0100 Subject: [PATCH] Properly trigger checkbox toggle on label click only MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixes #577 Signed-off-by: Julius Härtl --- js/controller/CardController.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/js/controller/CardController.js b/js/controller/CardController.js index acb235a30..b8cfa9b70 100644 --- a/js/controller/CardController.js +++ b/js/controller/CardController.js @@ -128,10 +128,11 @@ app.controller('CardController', function ($scope, $rootScope, $sce, $location, var checkboxId = $($event.target).data('id'); if ($event.target.tagName === 'LABEL') { $scope.toggleCheckbox(checkboxId); - return; + $event.stopPropagation(); + return false; } if ($event.target.tagName === 'INPUT') { - $scope.toggleCheckbox(checkboxId); + $event.stopPropagation(); return; } if (BoardService.isArchived() || CardService.getCurrent().archived) {