Switch from OC::$server->get to OCP\Server::get
And add a bit more typing to some classes + psalm issues Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This commit is contained in:
Carl Schwan
committed by
Julius Härtl
Julius Härtl
parent
2c7708dab1
commit
44481e1c2a
@@ -1,5 +1,5 @@
|
||||
<?xml version="1.0" encoding="UTF-8"?>
|
||||
<files psalm-version="4.22.0@fc2c6ab4d5fa5d644d8617089f012f3bb84b8703">
|
||||
<files psalm-version="4.23.0@f1fe6ff483bf325c803df9f510d09a03fd796f88">
|
||||
<file src="lib/Activity/ActivityManager.php">
|
||||
<TypeDoesNotContainType occurrences="1">
|
||||
<code>$message !== null</code>
|
||||
@@ -81,29 +81,6 @@
|
||||
<code>NotFound</code>
|
||||
</UndefinedClass>
|
||||
</file>
|
||||
<file src="lib/Db/AclMapper.php">
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$aclId</code>
|
||||
</ParamNameMismatch>
|
||||
</file>
|
||||
<file src="lib/Db/AssignmentMapper.php">
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$cardId</code>
|
||||
</ParamNameMismatch>
|
||||
</file>
|
||||
<file src="lib/Db/BoardMapper.php">
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$boardId</code>
|
||||
</ParamNameMismatch>
|
||||
<TypeDoesNotContainType occurrences="6">
|
||||
<code>$limit !== null</code>
|
||||
<code>$limit !== null</code>
|
||||
<code>$limit !== null</code>
|
||||
<code>$offset !== null</code>
|
||||
<code>$offset !== null</code>
|
||||
<code>$offset !== null</code>
|
||||
</TypeDoesNotContainType>
|
||||
</file>
|
||||
<file src="lib/Db/Card.php">
|
||||
<UndefinedClass occurrences="2">
|
||||
<code>VCalendar</code>
|
||||
@@ -114,39 +91,10 @@
|
||||
<InvalidScalarArgument occurrences="1">
|
||||
<code>$entity->getId()</code>
|
||||
</InvalidScalarArgument>
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$cardId</code>
|
||||
</ParamNameMismatch>
|
||||
<UndefinedInterfaceMethod occurrences="1">
|
||||
<code>getUserIdGroups</code>
|
||||
</UndefinedInterfaceMethod>
|
||||
</file>
|
||||
<file src="lib/Db/ChangeHelper.php">
|
||||
<UndefinedThisPropertyAssignment occurrences="3">
|
||||
<code>$this->cache</code>
|
||||
<code>$this->request</code>
|
||||
<code>$this->userId</code>
|
||||
</UndefinedThisPropertyAssignment>
|
||||
<UndefinedThisPropertyFetch occurrences="6">
|
||||
<code>$this->cache</code>
|
||||
<code>$this->cache</code>
|
||||
<code>$this->cache</code>
|
||||
<code>$this->cache</code>
|
||||
<code>$this->request</code>
|
||||
<code>$this->userId</code>
|
||||
</UndefinedThisPropertyFetch>
|
||||
</file>
|
||||
<file src="lib/Db/Circle.php">
|
||||
<UndefinedClass occurrences="1">
|
||||
<code>\OCA\Circles\Model\Circle</code>
|
||||
</UndefinedClass>
|
||||
<UndefinedDocblockClass occurrences="4">
|
||||
<code>$this->object</code>
|
||||
<code>$this->object</code>
|
||||
<code>$this->object</code>
|
||||
<code>\OCA\Circles\Model\Circle</code>
|
||||
</UndefinedDocblockClass>
|
||||
</file>
|
||||
<file src="lib/Db/LabelMapper.php">
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$labelId</code>
|
||||
@@ -158,29 +106,11 @@
|
||||
<code>VCalendar</code>
|
||||
</UndefinedClass>
|
||||
</file>
|
||||
<file src="lib/Db/StackMapper.php">
|
||||
<ParamNameMismatch occurrences="1">
|
||||
<code>$stackId</code>
|
||||
</ParamNameMismatch>
|
||||
</file>
|
||||
<file src="lib/Migration/Version10800Date20220422061816.php">
|
||||
<MoreSpecificImplementedParamType occurrences="1">
|
||||
<code>$schemaClosure</code>
|
||||
</MoreSpecificImplementedParamType>
|
||||
</file>
|
||||
<file src="lib/Notification/Notifier.php">
|
||||
<RedundantCast occurrences="4">
|
||||
<code>(string) $l->t('%s has mentioned you in a comment on "%s".', [$dn, $params[0]])</code>
|
||||
<code>(string) $l->t('The board "%s" has been shared with you by %s.', [$params[0], $dn])</code>
|
||||
<code>(string) $l->t('The card "%s" on "%s" has been assigned to you by %s.', [$params[0], $params[1], $dn])</code>
|
||||
<code>(string) $l->t('The card "%s" on "%s" has reached its due date.', $params)</code>
|
||||
</RedundantCast>
|
||||
</file>
|
||||
<file src="lib/Provider/DeckProvider.php">
|
||||
<InvalidPropertyAssignmentValue occurrences="1">
|
||||
<code>[]</code>
|
||||
</InvalidPropertyAssignmentValue>
|
||||
</file>
|
||||
<file src="lib/Service/AssignmentService.php">
|
||||
<InvalidScalarArgument occurrences="2">
|
||||
<code>$cardId</code>
|
||||
@@ -196,75 +126,15 @@
|
||||
<code>findAll</code>
|
||||
</TooManyArguments>
|
||||
</file>
|
||||
<file src="lib/Service/CardService.php">
|
||||
<UndefinedDocblockClass occurrences="1">
|
||||
<code>\OCP\AppFramework\Db\</code>
|
||||
</UndefinedDocblockClass>
|
||||
</file>
|
||||
<file src="lib/Service/CirclesService.php">
|
||||
<UndefinedClass occurrences="1">
|
||||
<code>?Circle</code>
|
||||
</UndefinedClass>
|
||||
<UndefinedDocblockClass occurrences="3">
|
||||
<code>$circlesManager</code>
|
||||
<code>$circlesManager</code>
|
||||
<code>$circlesManager</code>
|
||||
</UndefinedDocblockClass>
|
||||
</file>
|
||||
<file src="lib/Service/CommentService.php">
|
||||
<UndefinedThisPropertyAssignment occurrences="2">
|
||||
<code>$this->cardMapper</code>
|
||||
<code>$this->permissionService</code>
|
||||
</UndefinedThisPropertyAssignment>
|
||||
<UndefinedThisPropertyFetch occurrences="8">
|
||||
<code>$this->cardMapper</code>
|
||||
<code>$this->cardMapper</code>
|
||||
<code>$this->cardMapper</code>
|
||||
<code>$this->cardMapper</code>
|
||||
<code>$this->permissionService</code>
|
||||
<code>$this->permissionService</code>
|
||||
<code>$this->permissionService</code>
|
||||
<code>$this->permissionService</code>
|
||||
</UndefinedThisPropertyFetch>
|
||||
</file>
|
||||
<file src="lib/Service/DefaultBoardService.php">
|
||||
<TypeDoesNotContainNull occurrences="6">
|
||||
<code>$color === false || $color === null</code>
|
||||
<code>$color === null</code>
|
||||
<code>$title === false || $title === null</code>
|
||||
<code>$title === null</code>
|
||||
<code>$userId === false || $userId === null</code>
|
||||
<code>$userId === null</code>
|
||||
</TypeDoesNotContainNull>
|
||||
<TypeDoesNotContainType occurrences="3">
|
||||
<code>$color === false</code>
|
||||
<code>$title === false</code>
|
||||
<code>$userId === false</code>
|
||||
</TypeDoesNotContainType>
|
||||
<UndefinedClass occurrences="1"/>
|
||||
</file>
|
||||
<file src="lib/Service/FileService.php">
|
||||
<MissingDependency occurrences="2">
|
||||
<code>$this->rootFolder</code>
|
||||
<code>IRootFolder</code>
|
||||
</MissingDependency>
|
||||
<RedundantCondition occurrences="2">
|
||||
<code>is_resource($content)</code>
|
||||
<code>is_resource($content)</code>
|
||||
</RedundantCondition>
|
||||
</file>
|
||||
<file src="lib/Service/FilesAppService.php">
|
||||
<MissingDependency occurrences="3">
|
||||
<code>$this->rootFolder</code>
|
||||
<code>$this->rootFolder</code>
|
||||
<code>IRootFolder</code>
|
||||
</MissingDependency>
|
||||
</file>
|
||||
<file src="lib/Service/PermissionService.php">
|
||||
<UndefinedClass occurrences="2">
|
||||
<code>$circle</code>
|
||||
<code>Member</code>
|
||||
</UndefinedClass>
|
||||
</file>
|
||||
<file src="lib/Service/StackService.php">
|
||||
<UndefinedClass occurrences="1">
|
||||
<code>BadRquestException</code>
|
||||
|
||||
Reference in New Issue
Block a user