From 3fe849b93c89d747e34a3dae58753e2806e749be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 10 Nov 2020 18:00:47 +0100
Subject: [PATCH] Propagate ETag when comments are made
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 lib/Activity/CommentEventHandler.php            | 9 ++++++++-
 tests/unit/Activity/CommentEventHandlerTest.php | 5 ++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/lib/Activity/CommentEventHandler.php b/lib/Activity/CommentEventHandler.php
index 530fde2a4..dc68c3239 100644
--- a/lib/Activity/CommentEventHandler.php
+++ b/lib/Activity/CommentEventHandler.php
@@ -24,6 +24,7 @@
 namespace OCA\Deck\Activity;
 
 use OCA\Deck\Db\CardMapper;
+use OCA\Deck\Db\ChangeHelper;
 use OCA\Deck\Notification\NotificationHelper;
 use OCP\Comments\CommentsEvent;
 use OCP\Comments\IComment;
@@ -40,10 +41,14 @@ class CommentEventHandler implements ICommentsEventHandler {
 	/** @var CardMapper */
 	private $cardMapper;
 
-	public function __construct(ActivityManager $activityManager, NotificationHelper $notificationHelper, CardMapper $cardMapper) {
+	/** @var ChangeHelper */
+	private $changeHelper;
+
+	public function __construct(ActivityManager $activityManager, NotificationHelper $notificationHelper, CardMapper $cardMapper, ChangeHelper $changeHelper) {
 		$this->notificationHelper = $notificationHelper;
 		$this->activityManager = $activityManager;
 		$this->cardMapper = $cardMapper;
+		$this->changeHelper = $changeHelper;
 	}
 
 	/**
@@ -54,6 +59,8 @@ class CommentEventHandler implements ICommentsEventHandler {
 			return;
 		}
 
+		$this->changeHelper->cardChanged($event->getComment()->getObjectId());
+
 		$eventType = $event->getEvent();
 		if ($eventType === CommentsEvent::EVENT_ADD
 		) {
diff --git a/tests/unit/Activity/CommentEventHandlerTest.php b/tests/unit/Activity/CommentEventHandlerTest.php
index 522bab28c..107ba10cf 100644
--- a/tests/unit/Activity/CommentEventHandlerTest.php
+++ b/tests/unit/Activity/CommentEventHandlerTest.php
@@ -25,6 +25,7 @@ namespace OCA\Deck\Activity;
 
 use OCA\Deck\Db\Card;
 use OCA\Deck\Db\CardMapper;
+use OCA\Deck\Db\ChangeHelper;
 use OCA\Deck\Notification\NotificationHelper;
 use OCP\Comments\CommentsEvent;
 use OCP\Comments\IComment;
@@ -45,10 +46,12 @@ class CommentEventHandlerTest extends TestCase {
 		$this->activityManager = $this->createMock(ActivityManager::class);
 		$this->notificationHelper = $this->createMock(NotificationHelper::class);
 		$this->cardMapper = $this->createMock(CardMapper::class);
+		$this->changeHelper = $this->createMock(ChangeHelper::class);
 		$this->commentEventHandler = new CommentEventHandler(
 			$this->activityManager,
 			$this->notificationHelper,
-			$this->cardMapper
+			$this->cardMapper,
+			$this->changeHelper
 		);
 	}