ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

perform deep serialization/sanitizing of reference rich object to avoid caching issues

Browse Source 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
This commit is contained in:
Julien Veyssier
2022-09-12 19:49:23 +02:00
parent 7c683efce6
commit 395c79b32a
1 changed files with 61 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
lib/Reference/CardReferenceProvider.php
View File

@@ -24,6 +24,10 @@ namespace OCA\Deck\Reference;
use OC\Collaboration\Reference\Reference; use OC\Collaboration\Reference\Reference;
use OCA\Deck\AppInfo\Application; use OCA\Deck\AppInfo\Application;
use OCA\Deck\Db\Assignment;
use OCA\Deck\Db\Attachment;
use OCA\Deck\Db\Label;
use OCA\Deck\Model\CardDetails;
use OCA\Deck\Service\BoardService; use OCA\Deck\Service\BoardService;
use OCA\Deck\Service\CardService; use OCA\Deck\Service\CardService;
use OCA\Deck\Service\StackService; use OCA\Deck\Service\StackService;
@@ -67,14 +71,20 @@ class CardReferenceProvider implements IReferenceProvider {
*/ */
public function resolveReference(string $referenceText): ?IReference { public function resolveReference(string $referenceText): ?IReference {
if ($this->matchReference($referenceText)) { if ($this->matchReference($referenceText)) {
$cardIds = $this->getBoardCardId($referenceText); $ids = $this->getBoardCardId($referenceText);
if ($cardIds !== null) { if ($ids !== null) {
[$boardId, $cardId] = $cardIds; [$boardId, $cardId] = $ids;
$card = $this->cardService->find((int) $cardId); $card = $this->cardService->find((int) $cardId)->jsonSerialize();
$board = $this->boardService->find((int) $boardId); $board = $this->boardService->find((int) $boardId)->jsonSerialize();
$stack = $this->stackService->find((int) $card->jsonSerialize()['stackId']); $stack = $this->stackService->find((int) $card['stackId'])->jsonSerialize();
$card = $this->sanitizeSerializedCard($card);
$board = $this->sanitizeSerializedBoard($board);
$stack = $this->sanitizeSerializedStack($stack);
$reference = new Reference($referenceText); $reference = new Reference($referenceText);
$reference->setRichObject(Application::APP_ID . '-card', [ $reference->setRichObject(Application::APP_ID . '-card', [
'id' => $boardId . '/' . $cardId,
'card' => $card, 'card' => $card,
'board' => $board, 'board' => $board,
'stack' => $stack, 'stack' => $stack,
@@ -86,6 +96,44 @@ class CardReferenceProvider implements IReferenceProvider {
return null; return null;
} }
private function sanitizeSerializedStack(array $stack): array {
$stack['cards'] = array_map(function (CardDetails $cardDetails) {
$result = $cardDetails->jsonSerialize();
unset($result['assignedUsers']);
return $result;
}, $stack['cards']);
return $stack;
}
private function sanitizeSerializedBoard(array $board): array {
unset($board['labels']);
$board['owner'] = $board['owner']->jsonSerialize();
unset($board['acl']);
unset($board['users']);
return $board;
}
private function sanitizeSerializedCard(array $card): array {
$card['labels'] = array_map(function (Label $label) {
return $label->jsonSerialize();
}, $card['labels']);
$card['assignedUsers'] = array_map(function (Assignment $assignment) {
$result = $assignment->jsonSerialize();
$result['participant'] = $result['participant']->jsonSerialize();
return $result;
}, $card['assignedUsers']);
$card['owner'] = $card['owner']->jsonSerialize();
unset($card['relatedStack']);
unset($card['relatedBoard']);
$card['attachments'] = array_map(function (Attachment $attachment) {
return $attachment->jsonSerialize();
}, $card['attachments']);
return $card;
}
private function getBoardCardId(string $url): ?array { private function getBoardCardId(string $url): ?array {
$start = $this->urlGenerator->getAbsoluteURL('/apps/' . Application::APP_ID); $start = $this->urlGenerator->getAbsoluteURL('/apps/' . Application::APP_ID);
$startIndex = $this->urlGenerator->getAbsoluteURL('/index.php/apps/' . Application::APP_ID); $startIndex = $this->urlGenerator->getAbsoluteURL('/index.php/apps/' . Application::APP_ID);
@@ -104,10 +152,16 @@ class CardReferenceProvider implements IReferenceProvider {
} }
public function getCachePrefix(string $referenceId): string { public function getCachePrefix(string $referenceId): string {
$ids = $this->getBoardCardId($referenceId);
if ($ids !== null) {
[$boardId, $cardId] = $ids;
return $boardId . '/' . $cardId;
}
return $referenceId; return $referenceId;
} }
public function getCacheKey(string $referenceId): ?string { public function getCacheKey(string $referenceId): ?string {
return null; return $this->userId ?? '';
} }
} }