ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

wrote attachment api controller, fixed bug caught by unit test in CardService

Browse Source 
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
This commit is contained in:
Ryan Fletcher
2018-07-24 11:21:33 -04:00
committed by Julius Härtl
parent e88c9a760d
commit 37a2858d5f
4 changed files with 90 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/unit/controller/AttachmentApiControllerTest.php
View File

@@ -47,7 +47,8 @@ class AttachmentApiControllerTest extends \Test\TestCase {
$this->attachmentService = $this->createMock(AttachmentService::class);
$this->controller = new AttachmentApiController(
$this->appName,
$this->request
$this->request,
$this->attachmentService
);
}
@@ -64,7 +65,7 @@ class AttachmentApiControllerTest extends \Test\TestCase {
->with('cardId')
->willReturn($allAttachments);
$expected = new DataResponse($this->attachmentExample, HTTP::STATUS_OK);
$expected = new DataResponse($allAttachments, HTTP::STATUS_OK);
$actual = $this->controller->getAll();
$this->assertEquals($expected, $actual);
}
@@ -91,6 +92,9 @@ class AttachmentApiControllerTest extends \Test\TestCase {
public function testCreate() {
$type = 'not null';
$data = ['not null'];
$this->attachmentService->expects($this->once())
->method('create')
->willReturn($this->attachmentExample);
@@ -101,12 +105,15 @@ class AttachmentApiControllerTest extends \Test\TestCase {
->willReturn($this->cardId);
$expected = new DataResponse($this->attachmentExample, HTTP::STATUS_OK);
$actual = $this->controller->create();
$actual = $this->controller->create($type, $data);
$this->assertEquals($expected, $actual);
}
public function testUpdate() {
// FIXME: what is data supposed to be in this context?
$data = ['not empty data'];
$this->attachmentService->expects($this->once())
->method('update')
->willReturn($this->attachmentExample);
@@ -121,7 +128,7 @@ class AttachmentApiControllerTest extends \Test\TestCase {
$this->attachmentExample->getId());
$expected = new DataResponse($this->attachmentExample, HTTP::STATUS_OK);
$actual = $this->controller->update();
$actual = $this->controller->update($data);
$this->assertEquals($expected, $actual);
}