Fix tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2019-03-14 22:47:43 +01:00
parent 6e4f8ca8ea
commit 33ca8a1827
2 changed files with 11 additions and 0 deletions

View File

@@ -25,6 +25,7 @@ class BoardTest extends TestCase {
'color' => "000000", 'color' => "000000",
'labels' => array(), 'labels' => array(),
'permissions' => [], 'permissions' => [],
'stacks' => [],
'deletedAt' => 0, 'deletedAt' => 0,
'lastModified' => 0, 'lastModified' => 0,
'acl' => array(), 'acl' => array(),
@@ -43,6 +44,7 @@ class BoardTest extends TestCase {
'color' => "000000", 'color' => "000000",
'labels' => array("foo", "bar"), 'labels' => array("foo", "bar"),
'permissions' => [], 'permissions' => [],
'stacks' => [],
'deletedAt' => 0, 'deletedAt' => 0,
'lastModified' => 0, 'lastModified' => 0,
'acl' => array(), 'acl' => array(),
@@ -68,6 +70,7 @@ class BoardTest extends TestCase {
'color' => "000000", 'color' => "000000",
'labels' => array(), 'labels' => array(),
'permissions' => [], 'permissions' => [],
'stacks' => [],
'deletedAt' => 0, 'deletedAt' => 0,
'lastModified' => 0, 'lastModified' => 0,
'acl' => array(), 'acl' => array(),

View File

@@ -33,6 +33,7 @@ use OCA\Deck\Db\Board;
use OCA\Deck\Db\BoardMapper; use OCA\Deck\Db\BoardMapper;
use OCA\Deck\Db\ChangeHelper; use OCA\Deck\Db\ChangeHelper;
use OCA\Deck\Db\LabelMapper; use OCA\Deck\Db\LabelMapper;
use OCA\Deck\Db\StackMapper;
use OCA\Deck\Notification\NotificationHelper; use OCA\Deck\Notification\NotificationHelper;
use OCP\IUser; use OCP\IUser;
use OCP\IUserManager; use OCP\IUserManager;
@@ -51,6 +52,8 @@ class BoardServiceTest extends TestCase {
private $aclMapper; private $aclMapper;
/** @var BoardMapper */ /** @var BoardMapper */
private $boardMapper; private $boardMapper;
/** @var StackMapper */
private $stackMapper;
/** @var PermissionService */ /** @var PermissionService */
private $permissionService; private $permissionService;
/** @var NotificationHelper */ /** @var NotificationHelper */
@@ -72,6 +75,7 @@ class BoardServiceTest extends TestCase {
$this->l10n = $this->createMock(L10N::class); $this->l10n = $this->createMock(L10N::class);
$this->aclMapper = $this->createMock(AclMapper::class); $this->aclMapper = $this->createMock(AclMapper::class);
$this->boardMapper = $this->createMock(BoardMapper::class); $this->boardMapper = $this->createMock(BoardMapper::class);
$this->stackMapper = $this->createMock(StackMapper::class);
$this->labelMapper = $this->createMock(LabelMapper::class); $this->labelMapper = $this->createMock(LabelMapper::class);
$this->permissionService = $this->createMock(PermissionService::class); $this->permissionService = $this->createMock(PermissionService::class);
$this->notificationHelper = $this->createMock(NotificationHelper::class); $this->notificationHelper = $this->createMock(NotificationHelper::class);
@@ -83,6 +87,7 @@ class BoardServiceTest extends TestCase {
$this->service = new BoardService( $this->service = new BoardService(
$this->boardMapper, $this->boardMapper,
$this->stackMapper,
$this->l10n, $this->l10n,
$this->labelMapper, $this->labelMapper,
$this->aclMapper, $this->aclMapper,
@@ -111,6 +116,9 @@ class BoardServiceTest extends TestCase {
->method('findAllByUser') ->method('findAllByUser')
->with('admin') ->with('admin')
->willReturn([$b1, $b2]); ->willReturn([$b1, $b2]);
$this->stackMapper->expects($this->any())
->method('findAll')
->willReturn([]);
$this->boardMapper->expects($this->once()) $this->boardMapper->expects($this->once())
->method('findAllByGroups') ->method('findAllByGroups')
->with('admin', ['a', 'b', 'c']) ->with('admin', ['a', 'b', 'c'])