diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php index 7df0a56a4..83f689955 100644 --- a/lib/Activity/DeckProvider.php +++ b/lib/Activity/DeckProvider.php @@ -79,7 +79,16 @@ class DeckProvider implements IProvider { /** * Map stored parameter objects to rich string types */ - $board = null; + + $author = $event->getAuthor(); + $user = $this->userManager->get($author); + $params = [ + 'user' => [ + 'type' => 'user', + 'id' => $author, + 'name' => $user !== null ? $user->getDisplayName() : $author + ], + ]; if ($event->getObjectType() === ActivityManager::DECK_OBJECT_BOARD) { $board = [ 'type' => 'highlight', @@ -87,19 +96,9 @@ class DeckProvider implements IProvider { 'name' => $event->getObjectName(), 'link' => $this->deckUrl('/board/' . $event->getObjectId()), ]; + $params['board'] = $board; } - $author = $event->getAuthor(); - $user = $this->userManager->get($author); - $params = [ - 'board' => $board, - 'user' => [ - 'type' => 'user', - 'id' => $author, - 'name' => $user !== null ? $user->getDisplayName() : $author - ], - ]; - if ($event->getObjectType() === ActivityManager::DECK_OBJECT_CARD) { $card = [ 'type' => 'highlight', diff --git a/tests/unit/Activity/DeckProviderTest.php b/tests/unit/Activity/DeckProviderTest.php index 971f50a7f..657dd01d5 100644 --- a/tests/unit/Activity/DeckProviderTest.php +++ b/tests/unit/Activity/DeckProviderTest.php @@ -180,7 +180,6 @@ class DeckProviderTest extends TestCase { 'name' => 'Board', 'link' => '#!/board/1', ], - 'card' => null, 'user' => [ 'type' => 'user', 'id' => 'admin', @@ -216,7 +215,6 @@ class DeckProviderTest extends TestCase { $this->provider->parse('en_US', $event); $data = [ - 'board' => null, 'card' => [ 'type' => 'highlight', 'id' => 1, @@ -266,7 +264,6 @@ class DeckProviderTest extends TestCase { $this->provider->parse('en_US', $event); $data = [ - 'board' => null, 'card' => [ 'type' => 'highlight', 'id' => 1,