ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

committing WIP (improving error validation across the api's)

Browse Source 
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
This commit is contained in:
Ryan Fletcher
2018-07-13 15:44:48 -04:00
committed by Julius Härtl
parent a388d199dc
commit 2668f6b80c
4 changed files with 77 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lib/Controller/Helper/ApiHelper.php
View File

@@ -28,17 +28,35 @@ use OCP\AppFramework\Http;
class ApiHelper {
public static function entityHasError($entityId, $entityName, $service) {
if (is_numeric($entityId) === false) {
$error['message'] = $entityName . ' id must be a number';
public static function boardHasError($boardId, $boardService) {
if (is_numeric($boardId) === false) {
$error['message'] = 'board id must be a number';
$error['status'] = HTTP::STATUS_BAD_REQUEST;
return $error;
}
$entity = $service->find($entityId);
$board = $boardService->find($boardId);
if ($entity === false || $entity === null) {
$error['message'] = 'Board does not exist';
if ($board === false || $board === null) {
$error['message'] = 'board does not exist';
$error['status'] = HTTP::STATUS_NOT_FOUND;
return $error;
}
return false;
}
public static function stackHasError($stackId, $stackService) {
if (is_numeric($stackId) === false) {
$error['message'] = 'board id must be a number';
$error['status'] = HTTP::STATUS_BAD_REQUEST;
return $error;
}
$stack = $stackService->find($stackId);
if ($stack === false || $stack === null) {
$error['message'] = 'stack does not exist';
$error['status'] = HTTP::STATUS_NOT_FOUND;
return $error;
}