ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Remove redundant is_array checks on return result from LabelMapper::findAll

Browse Source 
Signed-off-by: Raul <raul@nextcloud.com>
This commit is contained in:
Raul
2022-04-13 12:40:05 +02:00
parent 815b8597d1
commit 1d5fdef4b4
1 changed files with 15 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
lib/Service/LabelService.php
View File

@@ -91,14 +91,12 @@ class LabelService {
$this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE); $this->permissionService->checkPermission(null, $boardId, Acl::PERMISSION_MANAGE);
$boardLabels = $this->labelMapper->findAll($boardId); $boardLabels = $this->labelMapper->findAll($boardId);
if (\is_array($boardLabels)) { foreach ($boardLabels as $boardLabel) {
foreach ($boardLabels as $boardLabel) { if ($boardLabel->getTitle() === $title) {
if ($boardLabel->getTitle() === $title) { throw new BadRequestException('title must be unique');
throw new BadRequestException('title must be unique'); break;
break; }
} }
}
}
if ($this->boardService->isArchived(null, $boardId)) { if ($this->boardService->isArchived(null, $boardId)) {
throw new StatusException('Operation not allowed. This board is archived.'); throw new StatusException('Operation not allowed. This board is archived.');
@@ -163,17 +161,15 @@ class LabelService {
$label = $this->find($id); $label = $this->find($id);
$boardLabels = $this->labelMapper->findAll($label->getBoardId()); $boardLabels = $this->labelMapper->findAll($label->getBoardId());
if (\is_array($boardLabels)) { foreach ($boardLabels as $boardLabel) {
foreach ($boardLabels as $boardLabel) { if ($boardLabel->getId() === $label->getId()) {
if ($boardLabel->getId() === $label->getId()) { continue;
continue; }
} if ($boardLabel->getTitle() === $title) {
if ($boardLabel->getTitle() === $title) { throw new BadRequestException('title must be unique');
throw new BadRequestException('title must be unique'); break;
break; }
} }
}
}
if ($this->boardService->isArchived($this->labelMapper, $id)) { if ($this->boardService->isArchived($this->labelMapper, $id)) {
throw new StatusException('Operation not allowed. This board is archived.'); throw new StatusException('Operation not allowed. This board is archived.');