ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #3713 from nextcloud/backport/3670/stable23

Browse Source 
[stable23] Properly check for the stack AND setting board permissions
This commit is contained in:
Julius Härtl
2022-04-11 18:28:14 +02:00
committed by GitHub
parent 03a9915dd5 47345e10f1
commit 1bd62d7fa2
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Service/StackService.php
View File

@@ -290,10 +290,13 @@ class StackService {
throw new BadRequestException('order must be a number');
}
$this->permissionService->checkPermission($this->stackMapper, $boardId, Acl::PERMISSION_MANAGE);
if ($this->boardService->isArchived($this->stackMapper, $boardId)) {
$this->permissionService->checkPermission($this->stackMapper, $id, Acl::PERMISSION_MANAGE);
$this->permissionService->checkPermission($this->boardMapper, $boardId, Acl::PERMISSION_MANAGE);
if ($this->boardService->isArchived($this->stackMapper, $id)) {
throw new StatusException('Operation not allowed. This board is archived.');
}
$stack = $this->stackMapper->find($id);
$changes = new ChangeSet($stack);
$stack->setTitle($title);