Default valute to board property fix command flow and refactor

Fixes on getBoard tests
Refactor
Reduce psalm info
Refactor to implement pattern
Change order of methods to put all abstract first and all public first

Signed-off-by: Vitor Mattos <vitor@php.rio>
This commit is contained in:
Vitor Mattos
2021-07-19 09:03:42 -03:00
committed by Julius Härtl
parent 6714c89220
commit 19c609540b
8 changed files with 388 additions and 309 deletions

View File

@@ -114,10 +114,9 @@ class BoardImportCommandService extends BoardImportService {
$this->getOutput()->writeln('Valid schema:');
$schemaPath = __DIR__ . '/fixtures/config-' . $this->getSystem() . '-schema.json';
$this->getOutput()->writeln(print_r(file_get_contents($schemaPath), true));
$this->getInput()->setOption('config', null);
$this->getInput()->setOption('config', '');
}
parent::validateConfig();
return;
$this->validateConfig();
}
public function validateSystem(): void {
@@ -186,9 +185,9 @@ class BoardImportCommandService extends BoardImportService {
$this->importCards();
$this->getOutput()->writeln('Assign cards to labels...');
$this->assignCardsToLabels();
$this->getOutput()->writeln('Iporting comments...');
$this->getOutput()->writeln('Importing comments...');
$this->importComments();
$this->getOutput()->writeln('Iporting participants...');
$this->importParticipants();
$this->getOutput()->writeln('Importing participants...');
$this->importCardAssignments();
}
}