ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Get rid of unneeded sql queries

Browse Source
This commit is contained in:
Julius Haertl
2016-10-30 13:21:05 +01:00
parent 83e2cb0a61
commit 0db8b5646a
2 changed files with 76 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Db/BoardMapper.php
View File

@@ -52,18 +52,23 @@ class BoardMapper extends DeckMapper implements IPermissionMapper {
$board = $this->findEntity($sql, [$id]); $board = $this->findEntity($sql, [$id]);
// Add labels // Add labels
if ($withLabels) {
$labels = $this->labelMapper->findAll($id); $labels = $this->labelMapper->findAll($id);
$board->setLabels($labels); $board->setLabels($labels);
}
// Add acl // Add acl
if ($withAcl) {
$acl = $this->aclMapper->findAll($id); $acl = $this->aclMapper->findAll($id);
$board->setAcl($acl); $board->setAcl($acl);
}
return $board; return $board;
} }
/** /**
* Find all boards for a given user * Find all boards for a given user
*
* @param $userId * @param $userId
* @param null $limit * @param null $limit
* @param null $offset * @param null $offset

2
lib/Service/CardService.php
View File

@@ -97,7 +97,7 @@ class CardService {
$this->cardMapper->update($card); $this->cardMapper->update($card);
} }
// FIXME: return reordered cards without an additional db query // FIXME: return reordered cards without an additional db query
//$cards = $this->cardMapper->findAll($stackId); $cards = $this->cardMapper->findAll($stackId);
return $cards; return $cards;
} }