Fix codacy warnings

Signed-off-by: Julius Härtl <jus@bitgrid.net>

js/controller/CardController.js

@@ -20,7 +20,7 @@
  *  
  */
 
-/* global app moment */
+/* global app moment angular OC */
 import app from '../app/App.js';
 
 app.controller('CardController', function ($scope, $rootScope, $sce, $location, $stateParams, $state, $interval, $timeout, $filter, BoardService, CardService, StackService, StatusService, markdownItConverter, FileService) {

js/filters/bytesFilter.js

@@ -27,7 +27,7 @@ app.filter('bytes', function () {
 		if (isNaN(parseFloat(bytes, 10)) || !isFinite(bytes)) {
 			return '-';
 		}
-		if (precision === undefined) {
+		if (typeof precision === 'undefined') {
 			precision = 2;
 		}
 		var units = ['bytes', 'KB', 'MB', 'GB', 'TB', 'PB'],

js/service/ApiService.js

@@ -125,7 +125,7 @@ app.factory('ApiService', function ($http, $q) {
 			this.data[entity.id] = entity;
 		} else {
 			Object.keys(entity).forEach(function (key) {
-				if (entity[key] !== null) {
+				if (entity[key] !== null && element[key] !== entity[key]) {
 					element[key] = entity[key];
 				}
 			});

js/service/FileService.js

@@ -22,6 +22,7 @@
 
 import app from '../app/App.js';
 
+/* global OC oc_requesttoken */
 export default class FileService {
 
 	constructor ($http, FileUploader, CardService) {
@@ -51,7 +52,7 @@ export default class FileService {
 			};
 
 		this.uploader.uploadItem(fileItem);
-	};
+	}
 
 	onAfterAddingFile (fileItem) {
 		// Fetch card details before trying to upload so we can detect filename collisions properly
@@ -87,11 +88,11 @@ export default class FileService {
 
 		});
 
-	};
+	}
 
 	onSuccessItem(item, response) {
 		let attachments = this.cardservice.get(item.cardId).attachments;
-		let index = attachments.indexOf(attachments.find(attachment => attachment.id === response.id));
+		let index = attachments.indexOf(attachments.find((attachment) => attachment.id === response.id));
 		if (~index) {
 			attachments = attachments.splice(index, 1);
 		}

js/service/StackService.js

@@ -21,6 +21,7 @@
  */
 import app from '../app/App.js';
 
+/* global app angular */
 app.factory('StackService', function (ApiService, CardService, $http, $q) {
 	var StackService = function ($http, ep, $q) {
 		ApiService.call(this, $http, ep, $q);