From 06078c85ee125a37fa7d8b3a443e16c7cf9ba0c3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Thu, 20 Aug 2020 11:47:35 +0200
Subject: [PATCH] Cleanup frontend code
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 src/components/Controls.vue                 |  7 +++----
 src/components/cards/CardItem.vue           |  2 +-
 src/components/navigation/AppNavigation.vue | 14 +-------------
 src/components/overview/Overview.vue        |  4 ++--
 src/store/card.js                           |  3 ---
 src/store/overview.js                       |  7 -------
 src/store/stack.js                          |  1 -
 7 files changed, 7 insertions(+), 31 deletions(-)

diff --git a/src/components/Controls.vue b/src/components/Controls.vue
index 258bae031..3017f9a96 100644
--- a/src/components/Controls.vue
+++ b/src/components/Controls.vue
@@ -30,9 +30,8 @@
 				({{ t('deck', 'Archived cards') }})
 			</p>
 		</div>
-		<div v-if="dashboardName" class="board-title">
-			<!-- <div :style="{backgroundColor: '#' + board.color}" class="board-bullet" /> -->
-			<h2><a href="#">{{ dashboardName }}</a></h2>
+		<div v-if="overviewName" class="board-title">
+			<h2><a href="#">{{ overviewName }}</a></h2>
 		</div>
 		<div v-if="board" class="board-actions">
 			<div v-if="canManage && !showArchived && !board.archived"
@@ -210,7 +209,7 @@ export default {
 			required: false,
 			default: null,
 		},
-		dashboardName: {
+		overviewName: {
 			type: String,
 			required: false,
 			default: null,
diff --git a/src/components/cards/CardItem.vue b/src/components/cards/CardItem.vue
index 3d0207cbc..816d173ee 100644
--- a/src/components/cards/CardItem.vue
+++ b/src/components/cards/CardItem.vue
@@ -154,7 +154,7 @@ export default {
 	},
 	methods: {
 		openCard() {
-			const boardId = this.card ? this.card.boardId : this.$route.params.id
+			const boardId = this.card && this.card.boardId ? this.card.boardId : this.$route.params.id
 			this.$router.push({ name: 'card', params: { id: boardId, cardId: this.card.id } }).catch(() => {})
 		},
 		startEditing(card) {
diff --git a/src/components/navigation/AppNavigation.vue b/src/components/navigation/AppNavigation.vue
index 7d69bec0f..194e2a76d 100644
--- a/src/components/navigation/AppNavigation.vue
+++ b/src/components/navigation/AppNavigation.vue
@@ -72,10 +72,9 @@
 import axios from '@nextcloud/axios'
 import { mapGetters } from 'vuex'
 import ClickOutside from 'vue-click-outside'
-import { AppNavigation as AppNavigationVue, AppNavigationSettings, Multiselect } from '@nextcloud/vue'
+import { AppNavigation as AppNavigationVue, AppNavigationItem, AppNavigationSettings, Multiselect } from '@nextcloud/vue'
 import AppNavigationAddBoard from './AppNavigationAddBoard'
 import AppNavigationBoardCategory from './AppNavigationBoardCategory'
-import AppNavigationItem from '@nextcloud/vue/dist/Components/AppNavigationItem'
 import { loadState } from '@nextcloud/initial-state'
 import { generateUrl, generateOcsUrl } from '@nextcloud/router'
 
@@ -107,15 +106,6 @@ export default {
 			groupLimit: [],
 			groupLimitDisabled: true,
 			canCreate: canCreateState,
-			allDashboards: [{
-				id: 1,
-				title: 'due',
-				color: '999999',
-				acl: [],
-				permissions: {
-					PERMISSION_MANAGE: false,
-				},
-			}],
 		}
 	},
 	computed: {
@@ -123,11 +113,9 @@ export default {
 			'noneArchivedBoards',
 			'archivedBoards',
 			'sharedBoards',
-			// 'dashboards',
 		]),
 		isAdmin() {
 			// eslint-disable-next-line
-			//return oc_isadmin
 			return OC.isUserAdmin()
 		},
 	},
diff --git a/src/components/overview/Overview.vue b/src/components/overview/Overview.vue
index 32c5e9e72..ac4a783cd 100644
--- a/src/components/overview/Overview.vue
+++ b/src/components/overview/Overview.vue
@@ -90,7 +90,7 @@ const FILTER_ASSIGNED = 'assigned'
 
 const SUPPORTED_FILTERS = [
 	FILTER_ASSIGNED,
-	FILTER_DUE
+	FILTER_DUE,
 ]
 
 export default {
@@ -105,7 +105,7 @@ export default {
 			default: '',
 		},
 	},
-	data: function() {
+	data() {
 		return {
 			loading: true,
 		}
diff --git a/src/store/card.js b/src/store/card.js
index d3061cb18..4f4f4c987 100644
--- a/src/store/card.js
+++ b/src/store/card.js
@@ -96,9 +96,6 @@ export default {
 		},
 	},
 	mutations: {
-		clearCards(state) {
-			state.cards = []
-		},
 		addCard(state, card) {
 			card.labels = card.labels || []
 			card.assignedUsers = card.assignedUsers || []
diff --git a/src/store/overview.js b/src/store/overview.js
index b5c90b362..438ee8e59 100644
--- a/src/store/overview.js
+++ b/src/store/overview.js
@@ -32,12 +32,6 @@ export default {
 		assignedCards: [],
 	},
 	getters: {
-		dueOverdue: state => {
-			return state.withDue.filter((card) => {
-				return card
-			})
-
-		},
 		withDueDashboard: state => {
 			return state.withDue
 		},
@@ -52,7 +46,6 @@ export default {
 		setAssignedCards(state, assignedCards) {
 			state.assignedCards = assignedCards
 		},
-
 	},
 	actions: {
 		async loadDueDashboard({ commit }) {
diff --git a/src/store/stack.js b/src/store/stack.js
index afaa1a496..3f428e71f 100644
--- a/src/store/stack.js
+++ b/src/store/stack.js
@@ -76,7 +76,6 @@ export default {
 				})
 		},
 		async loadStacks({ commit }, boardId) {
-			commit('clearCards')
 			let call = 'loadStacks'
 			if (this.state.showArchived === true) {
 				call = 'loadArchivedStacks'