Adapt existing unit tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2018-06-12 17:24:00 +02:00
parent 757b041f73
commit 04b0807a12
4 changed files with 19 additions and 3 deletions

View File

@@ -23,20 +23,28 @@
namespace OCA\Deck\Cron; namespace OCA\Deck\Cron;
use OCA\Deck\Db\AttachmentMapper;
use OCA\Deck\Db\Board; use OCA\Deck\Db\Board;
use OCA\Deck\Db\BoardMapper; use OCA\Deck\Db\BoardMapper;
use OCA\Deck\Service\AttachmentService;
class DeleteCronTest extends \Test\TestCase { class DeleteCronTest extends \Test\TestCase {
/** @var BoardMapper|\PHPUnit_Framework_MockObject_MockObject */ /** @var BoardMapper|\PHPUnit_Framework_MockObject_MockObject */
protected $boardMapper; protected $boardMapper;
/** @var AttachmentService|\PHPUnit_Framework_MockObject_MockObject */
private $attachmentService;
/** @var AttachmentMapper|\PHPUnit_Framework_MockObject_MockObject */
private $attachmentMapper;
/** @var DeleteCron */ /** @var DeleteCron */
protected $deleteCron; protected $deleteCron;
public function setUp() { public function setUp() {
parent::setUp(); parent::setUp();
$this->boardMapper = $this->createMock(BoardMapper::class); $this->boardMapper = $this->createMock(BoardMapper::class);
$this->deleteCron = new DeleteCron($this->boardMapper); $this->attachmentService = $this->createMock(AttachmentService::class);
$this->attachmentMapper = $this->createMock(AttachmentMapper::class);
$this->deleteCron = new DeleteCron($this->boardMapper, $this->attachmentService, $this->attachmentMapper);
} }
protected function getBoard($id) { protected function getBoard($id) {

View File

@@ -77,6 +77,7 @@ class CardTest extends \PHPUnit_Framework_TestCase {
'duedate' => null, 'duedate' => null,
'overdue' => 0, 'overdue' => 0,
'archived' => false, 'archived' => false,
'attachments' => null,
'assignedUsers' => null, 'assignedUsers' => null,
], $card->jsonSerialize()); ], $card->jsonSerialize());
} }
@@ -97,6 +98,7 @@ class CardTest extends \PHPUnit_Framework_TestCase {
'duedate' => null, 'duedate' => null,
'overdue' => 0, 'overdue' => 0,
'archived' => false, 'archived' => false,
'attachments' => null,
'assignedUsers' => null, 'assignedUsers' => null,
], $card->jsonSerialize()); ], $card->jsonSerialize());
} }
@@ -127,6 +129,7 @@ class CardTest extends \PHPUnit_Framework_TestCase {
'duedate' => null, 'duedate' => null,
'overdue' => 0, 'overdue' => 0,
'archived' => false, 'archived' => false,
'attachments' => null,
'assignedUsers' => ['user1'], 'assignedUsers' => ['user1'],
], $card->jsonSerialize()); ], $card->jsonSerialize());
} }

View File

@@ -55,7 +55,8 @@ class CardServiceTest extends TestCase {
$this->permissionService = $this->createMock(PermissionService::class); $this->permissionService = $this->createMock(PermissionService::class);
$this->boardService = $this->createMock(BoardService::class); $this->boardService = $this->createMock(BoardService::class);
$this->assignedUsersMapper = $this->createMock(AssignedUsersMapper::class); $this->assignedUsersMapper = $this->createMock(AssignedUsersMapper::class);
$this->cardService = new CardService($this->cardMapper, $this->stackMapper, $this->permissionService, $this->boardService, $this->assignedUsersMapper); $this->attachmentService = $this->createMock(AttachmentService::class);
$this->cardService = new CardService($this->cardMapper, $this->stackMapper, $this->permissionService, $this->boardService, $this->assignedUsersMapper, $this->attachmentService);
} }
public function testFind() { public function testFind() {

View File

@@ -54,6 +54,8 @@ class StackServiceTest extends TestCase {
private $permissionService; private $permissionService;
/** @var AssignedUsersMapper|\PHPUnit_Framework_MockObject_MockObject */ /** @var AssignedUsersMapper|\PHPUnit_Framework_MockObject_MockObject */
private $assignedUsersMapper; private $assignedUsersMapper;
/** @var AttachmentService|\PHPUnit_Framework_MockObject_MockObject */
private $attachmentService;
/** @var BoardService|\PHPUnit_Framework_MockObject_MockObject */ /** @var BoardService|\PHPUnit_Framework_MockObject_MockObject */
private $boardService; private $boardService;
@@ -65,6 +67,7 @@ class StackServiceTest extends TestCase {
$this->permissionService = $this->createMock(PermissionService::class); $this->permissionService = $this->createMock(PermissionService::class);
$this->boardService = $this->createMock(BoardService::class); $this->boardService = $this->createMock(BoardService::class);
$this->assignedUsersMapper = $this->createMock(AssignedUsersMapper::class); $this->assignedUsersMapper = $this->createMock(AssignedUsersMapper::class);
$this->attachmentService = $this->createMock(AttachmentService::class);
$this->stackService = new StackService( $this->stackService = new StackService(
$this->stackMapper, $this->stackMapper,
@@ -72,7 +75,8 @@ class StackServiceTest extends TestCase {
$this->labelMapper, $this->labelMapper,
$this->permissionService, $this->permissionService,
$this->boardService, $this->boardService,
$this->assignedUsersMapper $this->assignedUsersMapper,
$this->attachmentService
); );
} }