ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #1530 from nextcloud/bugfix/noid/comments-check

Browse Source 
Check for board membership on comments entity event
This commit is contained in:
Julius Härtl
2020-02-11 09:31:36 +01:00
committed by GitHub
parent d873763e02 0e7b3b17dd
commit 030998a2cc
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/AppInfo/Application.php
View File

@@ -38,6 +38,7 @@ use OCA\Deck\Middleware\DefaultBoardMiddleware;
use OCA\Deck\Middleware\ExceptionMiddleware; use OCA\Deck\Middleware\ExceptionMiddleware;
use OCA\Deck\Notification\Notifier; use OCA\Deck\Notification\Notifier;
use OCA\Deck\Service\FullTextSearchService; use OCA\Deck\Service\FullTextSearchService;
use OCA\Deck\Service\PermissionService;
use OCP\AppFramework\App; use OCP\AppFramework\App;
use OCP\Collaboration\Resources\IManager; use OCP\Collaboration\Resources\IManager;
use OCP\Collaboration\Resources\IProviderManager; use OCP\Collaboration\Resources\IProviderManager;
@@ -150,13 +151,14 @@ class Application extends App {
$this->server->getEventDispatcher()->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) { $this->server->getEventDispatcher()->addListener(CommentsEntityEvent::EVENT_ENTITY, function(CommentsEntityEvent $event) {
$event->addEntityCollection('deckCard', function($name) { $event->addEntityCollection('deckCard', function($name) {
/** @var CardMapper */ /** @var CardMapper */
$service = $this->getContainer()->query(CardMapper::class); $cardMapper = $this->getContainer()->query(CardMapper::class);
$permissionService = $this->getContainer()->query(PermissionService::class);
try { try {
$service->find((int) $name); return $permissionService->checkPermission($cardMapper, (int) $name, Acl::PERMISSION_READ);
} catch (InvalidArgumentException $e) { } catch (\Exception $e) {
return false; return false;
} }
return true;
}); });
}); });
$this->registerCommentsEventHandler(); $this->registerCommentsEventHandler();