ahtlon/deck
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Catch exceptions and only cast when necessary

Browse Source 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl
2019-04-10 15:41:32 +02:00
parent 6af28f1b79
commit 0258b74b42
1 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lib/Service/FullTextSearchService.php
View File

@@ -40,6 +40,7 @@ use OCA\Deck\Db\StackMapper;
use OCA\Deck\Provider\DeckProvider; use OCA\Deck\Provider\DeckProvider;
use OCP\AppFramework\Db\DoesNotExistException; use OCP\AppFramework\Db\DoesNotExistException;
use OCP\AppFramework\Db\MultipleObjectsReturnedException; use OCP\AppFramework\Db\MultipleObjectsReturnedException;
use OCP\FullTextSearch\Exceptions\FullTextSearchAppNotAvailableException;
use OCP\FullTextSearch\IFullTextSearchManager; use OCP\FullTextSearch\IFullTextSearchManager;
use OCP\FullTextSearch\Model\IDocumentAccess; use OCP\FullTextSearch\Model\IDocumentAccess;
use OCP\FullTextSearch\Model\IIndex; use OCP\FullTextSearch\Model\IIndex;
@@ -92,12 +93,15 @@ class FullTextSearchService {
* @param GenericEvent $e * @param GenericEvent $e
*/ */
public function onCardCreated(GenericEvent $e) { public function onCardCreated(GenericEvent $e) {
$cardId = (int)$e->getArgument('id'); $cardId = $e->getArgument('id');
$userId = $e->getArgument('userId'); $userId = $e->getArgument('userId');
try {
$this->fullTextSearchManager->createIndex( $this->fullTextSearchManager->createIndex(
DeckProvider::DECK_PROVIDER_ID, (string)$cardId, $userId, IIndex::INDEX_FULL DeckProvider::DECK_PROVIDER_ID, (string)$cardId, $userId, IIndex::INDEX_FULL
); );
} catch (FullTextSearchAppNotAvailableException $e) {
}
} }
@@ -105,11 +109,14 @@ class FullTextSearchService {
* @param GenericEvent $e * @param GenericEvent $e
*/ */
public function onCardUpdated(GenericEvent $e) { public function onCardUpdated(GenericEvent $e) {
$cardId = (int)$e->getArgument('id'); $cardId = $e->getArgument('id');
try {
$this->fullTextSearchManager->updateIndexStatus( $this->fullTextSearchManager->updateIndexStatus(
DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_CONTENT DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_CONTENT
); );
} catch (FullTextSearchAppNotAvailableException $e) {
}
} }
@@ -117,11 +124,14 @@ class FullTextSearchService {
* @param GenericEvent $e * @param GenericEvent $e
*/ */
public function onCardDeleted(GenericEvent $e) { public function onCardDeleted(GenericEvent $e) {
$cardId = (int)$e->getArgument('id'); $cardId = $e->getArgument('id');
try {
$this->fullTextSearchManager->updateIndexStatus( $this->fullTextSearchManager->updateIndexStatus(
DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_REMOVE DeckProvider::DECK_PROVIDER_ID, (string)$cardId, IIndex::INDEX_REMOVE
); );
} catch (FullTextSearchAppNotAvailableException $e) {
}
} }
@@ -137,9 +147,12 @@ class FullTextSearchService {
}, },
$this->getCardsFromBoard($boardId) $this->getCardsFromBoard($boardId)
); );
try {
$this->fullTextSearchManager->updateIndexesStatus( $this->fullTextSearchManager->updateIndexesStatus(
DeckProvider::DECK_PROVIDER_ID, $cards, IIndex::INDEX_META DeckProvider::DECK_PROVIDER_ID, $cards, IIndex::INDEX_META
); );
} catch (FullTextSearchAppNotAvailableException $e) {
}
} }
@@ -167,7 +180,7 @@ class FullTextSearchService {
$document->setTitle($card->getTitle()); $document->setTitle($card->getTitle());
$document->setContent($card->getDescription()); $document->setContent($card->getDescription());
$document->setAccess($this->generateDocumentAccessFromCardId($card->getId())); $document->setAccess($this->generateDocumentAccessFromCardId((int)$card->getId()));
} }
@@ -181,9 +194,7 @@ class FullTextSearchService {
public function generateDocumentAccessFromCardId(int $cardId): IDocumentAccess { public function generateDocumentAccessFromCardId(int $cardId): IDocumentAccess {
$board = $this->getBoardFromCardId($cardId); $board = $this->getBoardFromCardId($cardId);
$access = new DocumentAccess($board->getOwner()); return new DocumentAccess($board->getOwner());
return $access;
} }