diff --git a/lib/Controller/CardApiController.php b/lib/Controller/CardApiController.php index 54fe59ff5..2c598189d 100644 --- a/lib/Controller/CardApiController.php +++ b/lib/Controller/CardApiController.php @@ -76,7 +76,7 @@ class CardApiController extends ApiController { * * Get a specific card. */ - public function create($title, $type = 'plain', $order = 999, $description) { + public function create($title, $type = 'plain', $order = 999, $description = '') { $card = $this->cardService->create($title, $this->request->getParam('stackId'), $type, $order, $this->userId, $description); return new DataResponse($card, HTTP::STATUS_OK); } diff --git a/lib/Service/CardService.php b/lib/Service/CardService.php index d5449ee87..bc1cdf207 100644 --- a/lib/Service/CardService.php +++ b/lib/Service/CardService.php @@ -315,7 +315,7 @@ class CardService { // Trigger update events before setting description as it is handled separately $changes->setAfter($card); $this->activityManager->triggerUpdateEvents(ActivityManager::DECK_OBJECT_CARD, $changes, ActivityManager::SUBJECT_CARD_UPDATE); - + if ($card->getDescriptionPrev() === null) { $card->setDescriptionPrev($card->getDescription()); } @@ -324,7 +324,7 @@ class CardService { $card = $this->cardMapper->update($card); $this->changeHelper->cardChanged($card->getId(), true); - + $this->eventDispatcher->dispatch( '\OCA\Deck\Card::onUpdate', new GenericEvent(null, ['id' => $id, 'card' => $card]) ); @@ -440,7 +440,7 @@ class CardService { if (is_numeric($id) === false) { throw new BadRequestException('id must be a number'); } - + $this->permissionService->checkPermission($this->cardMapper, $id, Acl::PERMISSION_EDIT); if ($this->boardService->isArchived($this->cardMapper, $id)) { throw new StatusException('Operation not allowed. This board is archived.'); @@ -505,7 +505,7 @@ class CardService { if (is_numeric($cardId) === false) { throw new BadRequestException('card id must be a number'); } - + if (is_numeric($labelId) === false) { throw new BadRequestException('label id must be a number'); } @@ -597,7 +597,7 @@ class CardService { /* Notifyuser about the card assignment */ $this->notificationHelper->sendCardAssigned($card, $userId); } - + $assignment = new AssignedUsers(); $assignment->setCardId($cardId); $assignment->setParticipant($userId);