From 001609982d8f3dbd3d4158bb254b9b4d8483f7e7 Mon Sep 17 00:00:00 2001
From: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Date: Tue, 21 Aug 2018 17:11:47 -0400
Subject: [PATCH] adjusting solution based on standards shown to me by
 jancborchardt

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
---
 js/controller/ListController.js |  2 +-
 templates/part.boardlist.php    | 19 +++++++++++--------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/js/controller/ListController.js b/js/controller/ListController.js
index f3c0baefd..6cd1472fd 100644
--- a/js/controller/ListController.js
+++ b/js/controller/ListController.js
@@ -56,7 +56,7 @@ var ListController = function ($scope, $location, $filter, BoardService, $elemen
 	$scope.boardservice = BoardService;
 	$scope.updatingBoard = null;
 
-	var filterData = function () {
+	var filterData = function () {		
 		if($element.attr('id') === 'app-navigation') {
 			$scope.boardservice.sidebar = $scope.boardservice.getData();
 			$scope.boardservice.sidebar = $filter('orderBy')($scope.boardservice.sidebar, 'title');
diff --git a/templates/part.boardlist.php b/templates/part.boardlist.php
index f4e6aa19c..674eb71d5 100644
--- a/templates/part.boardlist.php
+++ b/templates/part.boardlist.php
@@ -13,7 +13,15 @@
 		</div>
 	</div>
 </div>
-<div id="boardlist">
+<div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'archived'">
+	<div class="icon-archive"></div>
+	<h2>No archived boards to display</h2>
+</div>
+<div id="emptycontent" ng-if="boardservice.sorted.length == 0 && status.filter == 'shared'">
+	<div class="icon-share"></div>
+	<h2>No shared boards to display</h2>
+</div>
+<div id="boardlist" ng-if="boardservice.sorted.length > 0 || !status.filter">
 	<table width="100%">
 		<thead>
 		<tr>
@@ -23,13 +31,8 @@
 			<td></td>
 		</tr>
 		</thead>
-		<tbody>
-		<tr ng-if="boardservice.sorted.length == 0">
-			<td class="center-text" colspan="4">
-				<?php p($l->t('There are no boards in this category to display')); ?>
-			</td>
-		</tr>
-		<tr ng-if="boardservice.sorted.length > 0" data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
+		<tbody>		
+		<tr data-ng-repeat="b in boardservice.sorted track by b.id" ng-class="{deleted: b.deletedAt > 0}">
 			<td ng-click="gotoBoard(b)">
 				<div class="board-bullet" ng-style="{'background-color':'#'+b.color}"> </div>
 			</td>